feat(deno): redis diagnostics channel based integration for deno#21087
Merged
Conversation
isaacs
requested review from
andreiborza and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
isaacs
added a commit
that referenced
this pull request
May 20, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
f176fd8 to
0fc320c
Compare
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
1048f32 to
72be1fa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
May 21, 2026
isaacs
added a commit
that referenced
this pull request
May 21, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
11525d8 to
a8d3cb7
Compare
isaacs
added a commit
that referenced
this pull request
May 21, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
May 21, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
8226aaf to
5863e6c
Compare
isaacs
added a commit
that referenced
this pull request
May 22, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
5863e6c to
cd298fa
Compare
Contributor
|
👋 @mydea, @andreiborza — Please review this PR when you get a chance! |
isaacs
added a commit
that referenced
this pull request
May 25, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
added a commit
that referenced
this pull request
May 27, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
e46685b to
1f6c601
Compare
JPeer264
reviewed
May 28, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM, just have one m which I want to get sorted before approving
JPeer264
reviewed
May 28, 2026
Contributor
|
👋 @mydea, @andreiborza — Please review this PR when you get a chance! |
mydea
requested review from
logaretm and
nicohrubec
and removed request for
mydea
Member
I'm personally fine with this. Approved the other PR, waiting for @isaacs decision. |
isaacs
added a commit
that referenced
this pull request
May 28, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
1f6c601 to
6a2f9b6
Compare
) Refactor the redis and ioredis diagnostics_channel integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test covering both redis clients. fix: #21221 fix: JS-2630
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
6a2f9b6 to
ebbbc65
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ebbbc65. Configure here.
JPeer264
approved these changes
May 29, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. Lint is failing, but it looks like a small change.
logaretm
reviewed
May 29, 2026
| ): void { | ||
| const channel = tracingChannel<T>(channelName, data => { | ||
| const args = getCommandArgs(data); | ||
| const statement = safeSerialize(data.command, args); |
Member
There was a problem hiding this comment.
m: tracing channels on redis already sanitize the command statements or is that a different thing?
https://github.com/redis/ioredis/blob/main/lib/tracing.ts#L10-L22
https://github.com/logaretm/node-redis/blob/master/packages/client/lib/client/tracing.ts#L39-L44
It was based off the one implemented by OTEL originally, and Redis team wanted Redis to own that part.
Member
Author
There was a problem hiding this comment.
Ooh, good catch. Yes, this was ported in from the otel implementation, and looks like we missed it the first time around, but it's just spinning extra CPU cycles unnecessarily, since the dc publishers already do this for us.
Member
Author
There was a problem hiding this comment.
This also means we don't have to handle Uint8Array/Buffer args, which simplifies it even further, actually.
Member
Author
logaretm
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the redis and ioredis diagnostics_channel integration logic into core/src/integrations, and create a Deno integration that uses the same patterns.
Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration adds
_sentrySpanonto the data in a RedisTracingChannelFactory which is passed to the core utility.Add deno-redis e2e test covering both redis clients.
fix: #21221
fix: JS-2630